View Single Post
Old 22-06-16, 17:03   #1990
vvsgh
Student
 
Join Date: Jun 2015
Posts: 134
Default

Quote:
Originally Posted by Cochrane View Post
The idea is not that everyone has to test on all platforms before making a merge request. But going with merge requests means people have a chance to look at the code, see what it's doing and how it's written, and propose changes where necessary before adding it to the master tree.
That's certainly true. But it doesn't work that well in practice. Remember how it was with Steffen's PR? And it wasn't exception. That's why GitHub implemented CI and protected branches. But it won't protect us from breakage that can't be discovered by an automatic test suite. So, in the end it still depends on a manual testing that require building many different branches in developer's workspaces. And this is more difficult if you have to test it separately from the main branch. That's why PRs are not getting enough attention which results in a poor quality.
vvsgh is offline   Reply With Quote